Replace @konveyor/lib-ui with @migtools/lib-ui#1471
Closed
mturley wants to merge 1 commit intomigtools:masterfrom
Closed
Replace @konveyor/lib-ui with @migtools/lib-ui#1471mturley wants to merge 1 commit intomigtools:masterfrom
@konveyor/lib-ui with @migtools/lib-ui#1471mturley wants to merge 1 commit intomigtools:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
Edit: actually, realizing the other change in this upgrade was a bump in the PatternFly versions used as peer dependencies in lib-ui. Marking this as a draft, may not return to it considering the status of mig-ui. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@konveyor/lib-uipackage has been migrated from thekonveyororg to themigtoolsorg as part of Konveyor being donated to the CNCF Sandbox. The npm package has been renamed to@migtools/lib-uistarting with the8.4.1release (see migtools/lib-ui#111).Upgrading lib-ui from 5.1.2 -> 8.4.1 involves the following breaking changes:
!field.isValidto show errors will now show validation errors on all required fields as soon as the form first renders. Consumers should replace the!field.isValidcondition withfield.shouldShowErroror!field.isValid && field.isTouched.None of these changes affect this repo because it is not using
useFormStateorValidatedTextInput, so renaming imports is the only source change necessary here.See also:
@konveyor/lib-uiwith@migtools/lib-uikubev2v/forklift-ui#984@konveyor/lib-uiwith@migtools/lib-uikubev2v/forklift-console-plugin#27@konveyor/lib-uiwith@migtools/lib-uicrane-ui-plugin#134@konveyor/lib-uiwith@migtools/lib-uiand upgrade peer dependencies konveyor/tackle2-ui#375