fix(web): Try xdg-open before hardcoded browsers#890
Open
ipilcher wants to merge 1 commit into
Open
Conversation
Currently, web.open_browser() doesn't always honor the user's browser preference on Linux. It tries x-www-browser, which is Debian (and derivatives)-specific, and it tries gnome-open, which was a GNOME 2 mechanism. This adds xdg-open to the list of "browsers", used by web.open_browser(), right before it starts trying specific browsers - Chrome, Chromium, Firefox, etc. Thus, users who are currently using the Debian alternatives system (or GNOME 2 settings) won't be affected by this change. Signed-off-by: Ian Pilcher <arequipeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
web.open_browser()doesn't always honor the user's browser preference on Linux. It triesx-www-browser, which is Debian (and derivatives)-specific, and it triesgnome-open, which was a GNOME 2 mechanism.This adds
xdg-opento the list of "browsers", used byweb.open_browser(), right before it starts trying specific browsers - Chrome, Chromium, Firefox, etc. Thus, users who are currently using the Debian alternatives system (or GNOME 2 settings) won't be affected by this change.