DOC: Add mne-videobrowser to related software#13544
DOC: Add mne-videobrowser to related software#13544ttaiv wants to merge 3 commits intomne-tools:mainfrom
Conversation
doc/sphinxext/related_software.py
Outdated
|
|
||
| # If it's available on PyPI, add it to this set: | ||
| PYPI_PACKAGES = { | ||
| "mne-videobrowser", |
There was a problem hiding this comment.
The preferred way actually is to add it here
We should add a note to this file, though, that this is the preferred method. That is, 1) get your package on PyPI and conda-forge, 2) add it to mne-installers recipe, and 3) update doc/sphinxext/related_software.py
If you need help adding to conda-forge let me know, but it's pretty painless nowadays using grayskull
There was a problem hiding this comment.
OK, I'll try to add it that way. But did I already update doc/sphinxext/related_software.py correctly? The file has comment # If a package is in MNE-Installers, it will be automatically added!, so I am wondering should I touch that file at all if I do steps 1) and 2). And how about the file doc/sphinxext/related_software.txt?
There was a problem hiding this comment.
We should update # If a package is in MNE-Installers, it will be automatically added! to say that it still needs to be added to doc/sphinxext/related_software.txt as CircleCI needs the software actually installed to pull the necessary info from it. So once your package is on conda-forge your PR here can 1) update that comment and 2) update related_software.txt
No need to list it there as it will be in mne-installers.
|
Opened companion PR mne-tools/mne-installers#409. That should land shortly, then I'll restart CircleCI here and we should magically see |
What does this implement/fix?
Adds mne-videobrowser Python package as related software.