Improve threading defaults, docs, and sys_info - #14103
Merged
Merged
Conversation
Member
Author
|
@cbrnr @drammock feel free to try! Ready for review/merge from my end. Test script to run while on this PR (mocks main behavior too)For me on my macOS laptop I get |
Contributor
|
Thanks @larsoner, I'll test tomorrow. Just one quick question, why are you using OpenBLAS on macOS and how did you install/enable it? From what I've read, Accelerate should be much faster in most scenarios. |
Member
Author
|
It's what our installers use by default. We should probably switch to accelerate there, I'll look into it (https://conda-forge.org/news/2025/07/31/new-accelerate-macos/) |
This was referenced Jul 27, 2026
cbrnr
reviewed
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Very nice! As expected, there's no effect when using Accelerate:
BLAS: accelerate (numpy build config, threads not introspectable)
CPUs: 12, PR caps at 3
median of 5 interleaved rounds
operation main PR speedup
-------------------------------------------
Maxwell tSSS 2.751s 2.719s 1.01x
Cov shrunk 1.532s 1.520s 1.01x
ICA 1.362s 1.383s 0.99x
Just two minor comments:
- Please use Accelerate and not accelerate in the
sys_infooutput (maybe also don't use all lower-case for all packages accordingly, e.g., NumPy, OpenMP, ...) - Make sure comments and docstrings are wrapped at 88 characters (it seems like they wrap much earlier, something like 72).
cbrnr
approved these changes
Jul 28, 2026
drammock
approved these changes
Jul 28, 2026
Member
|
thanks @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some modest progress toward #13766 -- better docs about how to control threads (our docs were wrong for anyone using our installers!) and add control mechanism to
sys_info. Implemented and figured out with the help of Claude Opus 5.Closes #13766