MRG, ENH: Add forward sensitivity maps to reports - #14107
Open
mariam-hedgie wants to merge 11 commits into
Open
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
Author
|
Member
|
Done! |
Author
|
Member
We plan to get rid of the matplotlib backend actually, so let's just remove code related to that and raise an error if 3D plotting can't be used |
Author
|
I have removed the matplotlib fallback, the CircleCI and Codecov checks pass, would a maintainer be able to approve the github workflow tests? thanks. |
Member
|
Done |
mariam-hedgie
marked this pull request as ready for review
July 28, 2026 07:30
mariam-hedgie
requested review from
agramfort,
drammock and
larsoner
as code owners
July 28, 2026 07:30
Author
|
I addressed the recent request to remove the Matplotlib fallback, and the checks are green. Would a maintainer please review this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2828
the missing feature:
MNE can already calculate sensitivity maps from a forward model to get information on how strongly each possible brain source would be measured by EEG/MEG sensors. however, the function
Report.add_forward()did not have an easy way for users to choose to include the sensitivity maps in an HTML report. This PR aims to fix users having to make maps manually and add them separately.new behavior:
Report.add_forward()testing:
Report.add_forward()functionAI disclosure:
Codex was used to help inspect the code and issue, implement changes, and run local checks. I reviewed the final diff, understand the changes and behavior, and reviewed the test results