feat: add enhanced element detection and mobile_tap_element tool #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve element detection to include interactive elements without visible text, and add convenient tool to find and tap elements by query. Android enhancements: - Add clickable, focusable, enabled, selected, package fields to UiAutomatorXmlNode - Include clickable/focusable elements (buttons, icons, views) in element detection - Change default element type from 'text' to 'element' for more accurate categorization New mobile_tap_element tool: - Search for elements by text, label, name, value, or identifier - Case-insensitive matching - Provides helpful errors when no match or multiple matches found - Automatically taps center of matching element - Works on both iOS and Android Co-Authored-By: Ben Myers <[email protected]>
Member
|
@jpsim hey, I understand the top part of the pull request. Same from @benlmyers . I haven't merged because I haven't been able to reproduce a problem with an app. I need to allocate time to write a sample app that doesn't work with the current code. As for the _tap_element, is it to save time? or does it solve other issues for you? Can you please explain the need for another tool? (tools cost context :P ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve element detection to include interactive elements without visible text,
and add convenient tool to find and tap elements by query.
Android enhancements:
New mobile_tap_element tool:
Co-Authored-By: @benlmyers