Reduce absolute time dependencies in tests#1649
Merged
PranavSenthilnathan merged 2 commits intoJun 24, 2026
Merged
Conversation
The test helper InMemoryTaskStore mutates TaskEntry fields without synchronization. FailTask/CompleteTask/CancelTask set Status before their payload field (Error/Result), so a concurrent reader in GetTask could observe Status == Failed with Error == null and throw 'Nullable object must have a value', surfacing to the client as a McpProtocolException instead of the expected McpException. Serialize all reads and writes under a lock on the backing dictionary, and reorder mutations so Status is assigned last. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
halter73
previously approved these changes
Jun 12, 2026
PranavSenthilnathan
changed the title
halter73
approved these changes
Jun 24, 2026
PranavSenthilnathan
merged commit e7b450e
into
modelcontextprotocol:main
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test helper InMemoryTaskStore mutates TaskEntry fields without synchronization. FailTask/CompleteTask/CancelTask set Status before their payload field (Error/Result), so a concurrent reader in GetTask could observe Status == Failed with Error == null and throw 'Nullable object must have a value', surfacing to the client as a McpProtocolException instead of the expected McpException.
Serialize all reads and writes under a lock on the backing dictionary, and reorder mutations so Status is assigned last.
In addition, use explicit signaling in tests instead of arbitrary wait times.
Fixes #1648
Fixes #1661