fix(http): drain SSE stream for connection reuse#790
Draft
Conversation
github-actions
bot
added
T-test
The SseAutoReconnectStream wrapper introduces a 3-second reconnect delay (from the priming event retry field) when the inner stream ends, preventing the 50ms drain from completing. Use a thin raw_sse_to_jsonrpc adapter for per-request POST SSE streams instead, so the stream ends immediately when the server closes the channel.
POST SSE response bodies cannot be fully consumed before the next request starts, causing reqwest to stall on pool checkout (~40ms). The long-lived GET SSE stream already holds its own connection, so there is no benefit to pooling POST connections with HTTP/1.1. This matches the workaround reported in #789.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #789
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context