Add Path validation #3164
Open
Add Path validation #3164
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation to ensure file paths are within repository boundaries before staging. This prevents potential issues with relative paths and improves overall robustness of the git_add function.
Use Git CLI directly instead of GitPython index API to ensure proper path validation and prevent option injection. The '--' separator ensures file paths starting with '-' are handled correctly.
…-git-add-validation # Conflicts: # src/git/src/mcp_server_git/server.py
Contributor
Author
|
@cliffhall @olahungerford @domdomegg Please take a look on this propose fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path Validation for GitPython inconsistent implementation
Description
Server Details
Motivation and Context
Fix Security Issue
How Has This Been Tested?
Existing Git Server Python Test cases, and Local MCP test.
Breaking Changes
No
Types of changes
Checklist
Additional context