fix(fetch): make Readability.js extraction opt-in - #4233
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Author
|
Quick follow-up: this still has the fetch package tests/build green and is scoped to making Readability.js extraction opt-in instead of changing plain fetch behavior by default. Could a maintainer take a look when convenient? |
LuuOW
reviewed
Jun 13, 2026
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: Verified MCP server implementation for consistency with current SDK patterns.
Author
|
Folding this into #4281, which covers the same Readability.js-vs-Python issue (#4199). I ended up preferring an automatic fallback when Node isn't available over flipping the default, since it's a smaller behavior change for existing users. Keeping that PR and closing this one to avoid three competing approaches on the same files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-server-fetchHTML extraction to readabilipy's Python parser instead of always enabling Readability.js--use-readabilityfor operators who explicitly want the Node-backed Readability.js pathCloses #4199.
To verify
uv run pytest -q --basetemp .tmp\pytest -p no:cacheprovideruv run ruff check src testsuv run pyright src testsuv run python -m py_compile src\mcp_server_fetch\server.py src\mcp_server_fetch\__init__.py