Skip to content

Preserve original root paths after realpath#4275

Open
yyzquwu wants to merge 1 commit into
modelcontextprotocol:mainfrom
yyzquwu:codex/preserve-roots-aliases
Open

Preserve original root paths after realpath#4275
yyzquwu wants to merge 1 commit into
modelcontextprotocol:mainfrom
yyzquwu:codex/preserve-roots-aliases

Conversation

@yyzquwu
Copy link
Copy Markdown

@yyzquwu yyzquwu commented Jun 1, 2026

Summary

  • preserve both configured and resolved MCP Roots directory forms when realpath changes the spelling
  • align Roots handling with existing command-line allowed-directory startup behavior
  • add a regression test using an alias directory so Windows mapped-drive/UNC-style rewrites keep both usable forms

Fixes #4129.

Verification

  • npm test --workspace src/filesystem
  • npm run build --workspace src/filesystem
  • Codex review: no actionable findings

Evidence

This is a non-UI filesystem path canonicalization fix, so there is no useful app screenshot to attach. The PR verification above is the relevant Windows evidence; the roots regression ran on Windows and the filesystem suite passed with 148 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filesystem server canonicalizes configured Windows mapped-drive paths to UNC at startup, then rejects identical-target Y:\ inputs

1 participant