[v1.x] fix: Update UriTemplate implementation to handle optional/omitted, out-of-order, and encoded query parameters #1083
+117
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyarmathy
force-pushed
the
1079-uritemplate-query-params
branch
2 times, most recently
from
5e2623c to
5950c61
Compare
mgyarmathy
changed the title
mgyarmathy
changed the title
mgyarmathy
force-pushed
the
1079-uritemplate-query-params
branch
from
5950c61 to
ee8c7f6
Compare
commit: |
mgyarmathy
force-pushed
the
1079-uritemplate-query-params
branch
2 times, most recently
from
c7b3331 to
6e5ff20
Compare
mgyarmathy
force-pushed
the
1079-uritemplate-query-params
branch
from
6e5ff20 to
6ec58ad
Compare
This was referenced Dec 17, 2025
|
Team - any chance of revisiting this PR? - Not being able to use optional query parameters is kinda limiting. |
Contributor
Author
|
I've updated the base branch for this so that the bugfix is backported to |
5 tasks
mgyarmathy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is the v1.x backport of #1396.
This PR addresses several limitations of the current
UriTemplate#matchimplementation:Omitted query parameters are parsed as an empty string per guidance of RFC 6570 Section 2.3.
Motivation and Context
Fixes #1079
Fixes #149
How Has This Been Tested?
New test additions cover all of the cases mentioned in #1079 and #149 as well as a few additional potential edge cases I could come up with.
Breaking Changes
n/a
Types of changes
Checklist
Additional context