fix: add @cfworker/json-schema as runtime dependency in client package#2144
Closed
sekerderya wants to merge 2 commits into
Closed
fix: add @cfworker/json-schema as runtime dependency in client package#2144sekerderya wants to merge 2 commits into
sekerderya wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 0de4e60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Verified that current main no longer reproduces the issue — importing @modelcontextprotocol/client after a fresh build succeeds without installing @cfworker/json-schema separately. Closing in favor of a new alpha publish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2143
Problem
@modelcontextprotocol/clientimports@cfworker/json-schemaat runtime(via
src/validators/cfWorker.ts) but does not declare it as a dependency.This causes
ERR_MODULE_NOT_FOUNDfor users who install the package, sincenpm/pnpm does not automatically install undeclared dependencies.
Manually installing
@cfworker/json-schemaworks around the issue, butusers should not need to do this.
Fix
Added
@cfworker/json-schemato thedependenciesfield inpackages/client/package.json.