Fix falsy-zero requestId bugs in cancel and debounce paths#2529
Open
kharerajat2014 wants to merge 1 commit into
Open
Fix falsy-zero requestId bugs in cancel and debounce paths#2529kharerajat2014 wants to merge 1 commit into
kharerajat2014 wants to merge 1 commit into
Conversation
JSON-RPC id 0 is legal and is the first id Protocol assigns; truthiness guards were dropping cancels and incorrectly debounce-coalescing related notifications. Add regression tests and a patch changeset. Fixes modelcontextprotocol#2283 Fixes modelcontextprotocol#2117 Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: af77aba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_oncancel: stop droppingnotifications/cancelledwhenrequestId === 0(legal JSON-RPC id; also the first idProtocolassigns via_requestMessageId = 0)relatedRequestId: 0as absent so related notifications are not incorrectly coalescedpackages/core-internal/test/shared/protocol.test.ts+ patch changeset for@modelcontextprotocol/core-internalFixes #2283
Fixes #2117
(Also related: #2115)
Note on overlapping PRs
#2504 and several other open PRs address the same root cause. Happy to close this in favor of whichever PR maintainers prefer, or adjust to a v1.x backport / e2e follow-up if that is more useful.
Test plan
pnpm --filter @modelcontextprotocol/core-internal exec vitest run test/shared/protocol.test.ts— 41 passed