Skip to content

Improve generic 'Method not found' message for better debuggability #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alantriesagain wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Improve generic 'Method not found' message for better debuggability #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/shared/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ export abstract class Protocol<SendRequestT extends Request, SendNotificationT e
id: request.id,
error: {
code: ErrorCode.MethodNotFound,
message: 'Method not found'
message: `Method '${request.method}' not found`
}
};

Expand Down
2 changes: 1 addition & 1 deletion test/integration/test/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,7 +2392,7 @@ describe('Task-based execution', () => {

// Try to get a task when server doesn't have TaskStore
// The server will return a "Method not found" error
await expect(client.experimental.tasks.getTask('non-existent')).rejects.toThrow('Method not found');
await expect(client.experimental.tasks.getTask('non-existent')).rejects.toThrow("Method 'tasks/get' not found");
});

test('should automatically attach related-task metadata to nested requests during tool execution', async () => {
Expand Down
Loading