Skip to content

fix: update JSON schema from draft-04 to draft 2020-12#174

Open
pradhyum6144 wants to merge 1 commit intomodelpack:mainfrom
pradhyum6144:fix/schema-draft-version
Open

fix: update JSON schema from draft-04 to draft 2020-12#174
pradhyum6144 wants to merge 1 commit intomodelpack:mainfrom
pradhyum6144:fix/schema-draft-version

Conversation

@pradhyum6144
Copy link

The schema declares draft-04 but uses keywords like $defs and $id which only exist in draft 2019-09+. Draft-04 uses definitions and id instead. This mismatch means strict draft-04 validators would ignore the type definitions entirely, causing silent validation failures for external consumers. Updated the $schema URI to draft 2020-12 and enabled format assertion in the validator since draft 2020-12 treats format as annotation-only by default.

Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pradhyum6144, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the declared JSON schema version (draft-04) was inconsistent with the advanced keywords being used in the schema definition. By upgrading the schema to draft 2020-12 and enabling strict format validation, it ensures that external consumers and validators correctly interpret and enforce the schema rules, preventing silent validation failures and improving the robustness of configuration validation.

Highlights

  • JSON Schema Version Update: The $schema URI in config-schema.json has been updated from draft-04 to draft 2020-12 to align with the actual keywords used (like $defs and $id) which are not supported in draft-04.
  • Enabled Format Assertion: The jsonschema validator in validator.go now explicitly enables AssertFormat, ensuring that format keywords are actively validated as required by draft 2020-12 (where they are annotation-only by default).
Changelog
  • schema/config-schema.json
    • Updated the JSON schema reference from draft-04 to draft 2020-12.
  • schema/validator.go
    • Enabled format assertion for the JSON schema compiler.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the JSON schema declaration from draft-04 to draft 2020-12 in config-schema.json and enables format assertion in the Go validator. These changes align with the pull request description, resolving the issue where newer JSON schema keywords were used with an older draft declaration, which could lead to silent validation failures. The implementation is straightforward and effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant