fix: update JSON schema from draft-04 to draft 2020-12#174
fix: update JSON schema from draft-04 to draft 2020-12#174pradhyum6144 wants to merge 1 commit intomodelpack:mainfrom
Conversation
Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
Summary of ChangesHello @pradhyum6144, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the declared JSON schema version ( Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly updates the JSON schema declaration from draft-04 to draft 2020-12 in config-schema.json and enables format assertion in the Go validator. These changes align with the pull request description, resolving the issue where newer JSON schema keywords were used with an older draft declaration, which could lead to silent validation failures. The implementation is straightforward and effective.
The schema declares draft-04 but uses keywords like $defs and $id which only exist in draft 2019-09+. Draft-04 uses definitions and id instead. This mismatch means strict draft-04 validators would ignore the type definitions entirely, causing silent validation failures for external consumers. Updated the $schema URI to draft 2020-12 and enabled format assertion in the validator since draft 2020-12 treats format as annotation-only by default.