Bson specification testing #1820
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes specification testing by moving the MongoDB specifications submodule from driver-core to a shared testing directory, updates JSON output for positive exponents to match the extended JSON specification, and adds comprehensive testing for BsonBinaryVector functionality.
- Moved specifications submodule from driver-core to shared testing directory for better organization
- Fixed JSON output to include explicit "+" signs for positive exponents in extended JSON
- Added comprehensive testing for BsonBinaryVector including prose tests and enhanced validation
Reviewed Changes
Copilot reviewed 47 out of 49 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .gitmodules | Updated submodule path from driver-core to testing directory |
| bson/build.gradle.kts | Added test resource processing to include shared testing resources |
| driver-core/build.gradle.kts | Added test resource processing to include shared testing resources |
| bson/src/main/org/bson/json/*.java | Modified double converters to use consistent JSON formatting with explicit positive exponents |
| bson/src/main/org/bson/BinaryVector.java | Added validation logging for non-zero padding bits |
| bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java | Enhanced test coverage and updated to use new spec test location |
| bson/src/test/unit/org/bson/*.java | Updated test references to use new specification test helper method |
| bson/src/test/resources/bson*/ | Removed old BSON specification test files (now using submodule) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vbabanin
reviewed
Oct 21, 2025
bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java
Outdated
Show resolved
Hide resolved
bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| tasks.processTestResources { | ||
| from("${rootProject.projectDir}/testing/resources") |
Member
There was a problem hiding this comment.
Nice! I think, In the future, we could also consider creating a separate module for testing utilities, so shared helpers can be reused across sync, reactive, core, and BSON modules.
Member
Author
|
@vbabanin I've updated the names of the tests to be more inline with the spec location and to identify the prose tests. I also moved the validation to the constructors as it seemed the best place to have it. |
rozza
commented
Oct 21, 2025
bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java
Outdated
Show resolved
Hide resolved
bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java
Outdated
Show resolved
Hide resolved
vbabanin
reviewed
Nov 20, 2025
vbabanin
reviewed
Dec 4, 2025
vbabanin
previously approved these changes
Jan 20, 2026
Moved specifications submodule out of driver-core into a testing directory. Deleted old copy of bson specification tests and updated to use the submodule Fixed Json output for positive exponents to match the the extended json specification Added test exceptions to BinaryVectorGenericBsonTest Added BsonBinaryVector prose tests Added extra regression tests to ensure both explicit and implicit doubles with positive exponets parse as expected. JAVA-5877 JAVA-5779 JAVA-5782 JAVA-5652
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
vbabanin
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved specifications submodule out of driver-core into a testing directory.
Deleted old copy of bson specification tests and updated to use the submodule
Fixed Json output for positive exponents to match the the extended json specification
Added test exceptions to BinaryVectorGenericBsonTest
Added BsonBinaryVector prose tests
Added extra regression tests to ensure both explicit and implicit doubles with positive exponets parse as expected.
JAVA-5877
JAVA-5779
JAVA-5782
JAVA-5652