PYTHON-5782 Coverage increase for message.py#2772
Draft
aclark4life wants to merge 5 commits intomongodb:masterfrom
Draft
PYTHON-5782 Coverage increase for message.py#2772aclark4life wants to merge 5 commits intomongodb:masterfrom
message.py#2772aclark4life wants to merge 5 commits intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new unit test module to increase coverage of pymongo/message.py by exercising message-building utilities and related pure-Python helper functions without requiring a live MongoDB server.
Changes:
- Adds
test/test_message.pywith unit tests for message helpers (read preference wrapping, command generation, write-result conversion). - Adds tests covering OP_MSG / OP_QUERY / OP_GET_MORE message construction in both compressed and uncompressed paths.
- Adds tests for error conversion and document-too-large error formatting.
- Replace _MockCtx with real ZlibContext(-1) to satisfy the SnappyContext | ZlibContext | ZstdContext union type - Annotate docs list as list to satisfy the Mapping invariance check - Add # type: ignore[arg-type] on _MockConn call sites for _gen_get_more_command (mocking AsyncConnection | Connection fully would require a much heavier stub)
aclark4life
force-pushed
the
PYTHON-5782
branch
2 times, most recently
from
a6c8f8e to
a8d9f92
Compare
aclark4life
force-pushed
the
PYTHON-5782
branch
2 times, most recently
from
0d4e27b to
b352a81
Compare
aclark4life
changed the title
aclark4life
changed the title
aclark4life
changed the title
message.py
aclark4life
changed the title
message.pymessage.py
aclark4life
changed the title
message.pymessage.py
aclark4life
changed the title
message.pymessage.py
Comment on lines
+28
to
+44
| from pymongo.compression_support import ZlibContext | ||
| from pymongo.errors import DocumentTooLarge, OperationFailure | ||
| from pymongo.message import ( | ||
| _compress, | ||
| _convert_client_bulk_exception, | ||
| _convert_exception, | ||
| _convert_write_result, | ||
| _gen_find_command, | ||
| _gen_get_more_command, | ||
| _get_more_compressed, | ||
| _get_more_uncompressed, | ||
| _maybe_add_read_preference, | ||
| _op_msg, | ||
| _query_compressed, | ||
| _query_uncompressed, | ||
| _raise_document_too_large, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5782
Changes in this PR
Adds
test/test_message.pywith unit tests forpymongo/message.py.Tests cover:
Result / error conversion
_convert_exception()_convert_client_bulk_exception()_convert_write_result()(insert/update/delete/upsert/wtimeout/errInfo branches)_raise_document_too_large()Wire-format message construction
_compress()_op_msg()(with/without compression)_query_uncompressed()/_query_compressed()_get_more_uncompressed()/_get_more_compressed()Command builders
_gen_find_command()_gen_get_more_command()Read preference
_maybe_add_read_preference()(PRIMARY, SECONDARY, SECONDARY_PREFERRED)Test Plan
Added unit tests using a real
ZlibContextfor compression paths and aMagicMockconnection for_gen_get_more_command. Focuses on the pure-Python code paths without requiring a live MongoDB server.Checklist
Checklist for Author
Checklist for Reviewer