chore: bump github.com/oasdiff/oasdiff from 1.23.0 to 1.24.0 in /tools/cli- #1385 - #1398
Draft
mongodb-sage-bot[bot] wants to merge 3 commits into
Draft
Conversation
Bumps [github.com/oasdiff/oasdiff](https://github.com/oasdiff/oasdiff) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/oasdiff/oasdiff/releases) - [Changelog](https://github.com/oasdiff/oasdiff/blob/main/docs/CHANGELOG-TEMPLATE.md) - [Commits](oasdiff/oasdiff@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: github.com/oasdiff/oasdiff dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
## Proposed changes Dependabot's config only watches `/tools/cli`, so PR #1385 bumped `github.com/oasdiff/oasdiff` to 1.24.0 (and its transitive `kin-openapi` to 0.143.0) in `tools/cli` alone. The oasdiff diff, checker, and load packages are actually consumed by the `tools/foas` library, which `tools/cli` pulls in via a `replace` directive and which shares the `tools/go.work` workspace. Leaving `tools/foas` on oasdiff 1.23.0 / kin-openapi 0.140.0 left the workspace on skewed versions: under the workspace and the replace directive MVS resolves oasdiff to 1.24.0, but `tools/foas/go.sum` had no entry for it, so building and testing foas failed — the failing integration/e2e job flagged in the ticket. This aligns `tools/foas` with `tools/cli`: - oasdiff 1.23.0 -> 1.24.0 - kin-openapi 0.140.0 -> 0.143.0 - oasdiff/yaml 0.1.0 -> 0.1.1 (indirect) - oasdiff/yaml3 0.0.13 -> 0.0.14 (indirect) - yuin/goldmark 1.8.2 -> 1.8.4 (indirect) All go.sum hashes are copied verbatim from the already-verified `tools/cli/go.sum`. No source changes are required. oasdiff 1.24.0 only adds `validate` lints (duplicate-enum-value, ambiguous-parameter-serialization) and reworks internal rule-ID handling; there are no behavior changes to the diff/checker output that the changelog and merge pipelines rely on, so this is not a behavior-breaking upgrade and the golden fixtures are unaffected. The kin-openapi 0.143.0 removal of the generic `openapi3.StringMap[V]` type (now plain `map[string]V`) does not affect foas: the token `StringMap` never appears in the module, and the one site that reads `Discriminator.Mapping` ranges over it and accesses the unchanged `MappingRef` value, which compiles identically. _Jira ticket:_ CLOUDP-427906 ## Checklist - [x] I have signed the MongoDB CLA - [ ] I have added tests that prove my fix is effective or that my feature works A dependency-version alignment carries no new behavior to test; the existing foas and CLI unit/e2e suites cover the oasdiff-backed paths.
Contributor
Author
|
Sage Bot can help with this pull request. Just |
matt-condon
changed the base branch from
dependabot/go_modules/tools/cli/github.com/oasdiff/oasdiff-1.24.0
to
main
July 28, 2026 10:16
Collaborator
|
@sage-bot this PR is now pointed to the Pipeline: https://github.com/mongodb/openapi/actions/runs/30350390783/job/90246462622?pr=1398 Failures: |
Contributor
Author
|
❌ Sage Bot - Unexpected Error Sage Bot ran into an unexpected error processing your request. If you need help, reach out in #ask-devprod. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Dependabot's config only watches
/tools/cli, so PR #1385 bumpedgithub.com/oasdiff/oasdiffto 1.24.0 (and its transitivekin-openapito 0.143.0) intools/clialone. The oasdiff diff,checker, and load packages are actually consumed by the
tools/foaslibrary, which
tools/clipulls in via areplacedirective and whichshares the
tools/go.workworkspace. Leavingtools/foason oasdiff1.23.0 / kin-openapi 0.140.0 left the workspace on skewed versions:
under the workspace and the replace directive MVS resolves oasdiff to
1.24.0, but
tools/foas/go.sumhad no entry for it, so building andtesting foas failed — the failing integration/e2e job flagged in the
ticket.
This aligns
tools/foaswithtools/cli:All go.sum hashes are copied verbatim from the already-verified
tools/cli/go.sum.No source changes are required. oasdiff 1.24.0 only adds
validatelints (duplicate-enum-value, ambiguous-parameter-serialization) and
reworks internal rule-ID handling; there are no behavior changes to the
diff/checker output that the changelog and merge pipelines rely on, so
this is not a behavior-breaking upgrade and the golden fixtures are
unaffected. The kin-openapi 0.143.0 removal of the generic
openapi3.StringMap[V]type (now plainmap[string]V) does not affectfoas: the token
StringMapnever appears in the module, and the onesite that reads
Discriminator.Mappingranges over it and accesses theunchanged
MappingRefvalue, which compiles identically.Jira ticket: CLOUDP-427906
Checklist
A dependency-version alignment carries no new behavior to test; the
existing foas and CLI unit/e2e suites cover the oasdiff-backed paths.
Important
MongoDB Contribution Guidelines
This pull request was generated by sage-bot on behalf of matt.condon@mongodb.com (ticket assignee). The assignee must self-review the changes before requesting review from another engineer.
The assignee is not allowed to merge their own PR without approval from another engineer.