Skip to content

chore: bump github.com/oasdiff/oasdiff from 1.23.0 to 1.24.0 in /tools/cli- #1385 - #1398

Draft
mongodb-sage-bot[bot] wants to merge 3 commits into
mainfrom
sage-bot/CLOUDP-427906/sage-CLOUDP-427906-1785192993602
Draft

chore: bump github.com/oasdiff/oasdiff from 1.23.0 to 1.24.0 in /tools/cli- #1385#1398
mongodb-sage-bot[bot] wants to merge 3 commits into
mainfrom
sage-bot/CLOUDP-427906/sage-CLOUDP-427906-1785192993602

Conversation

@mongodb-sage-bot

Copy link
Copy Markdown
Contributor

Proposed changes

Dependabot's config only watches /tools/cli, so PR #1385 bumped
github.com/oasdiff/oasdiff to 1.24.0 (and its transitive
kin-openapi to 0.143.0) in tools/cli alone. The oasdiff diff,
checker, and load packages are actually consumed by the tools/foas
library, which tools/cli pulls in via a replace directive and which
shares the tools/go.work workspace. Leaving tools/foas on oasdiff
1.23.0 / kin-openapi 0.140.0 left the workspace on skewed versions:
under the workspace and the replace directive MVS resolves oasdiff to
1.24.0, but tools/foas/go.sum had no entry for it, so building and
testing foas failed — the failing integration/e2e job flagged in the
ticket.

This aligns tools/foas with tools/cli:

  • oasdiff 1.23.0 -> 1.24.0
  • kin-openapi 0.140.0 -> 0.143.0
  • oasdiff/yaml 0.1.0 -> 0.1.1 (indirect)
  • oasdiff/yaml3 0.0.13 -> 0.0.14 (indirect)
  • yuin/goldmark 1.8.2 -> 1.8.4 (indirect)

All go.sum hashes are copied verbatim from the already-verified
tools/cli/go.sum.

No source changes are required. oasdiff 1.24.0 only adds validate
lints (duplicate-enum-value, ambiguous-parameter-serialization) and
reworks internal rule-ID handling; there are no behavior changes to the
diff/checker output that the changelog and merge pipelines rely on, so
this is not a behavior-breaking upgrade and the golden fixtures are
unaffected. The kin-openapi 0.143.0 removal of the generic
openapi3.StringMap[V] type (now plain map[string]V) does not affect
foas: the token StringMap never appears in the module, and the one
site that reads Discriminator.Mapping ranges over it and accesses the
unchanged MappingRef value, which compiles identically.

Jira ticket: CLOUDP-427906

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

A dependency-version alignment carries no new behavior to test; the
existing foas and CLI unit/e2e suites cover the oasdiff-backed paths.


Important

MongoDB Contribution Guidelines

This pull request was generated by sage-bot on behalf of matt.condon@mongodb.com (ticket assignee). The assignee must self-review the changes before requesting review from another engineer.
The assignee is not allowed to merge their own PR without approval from another engineer.

dependabot Bot and others added 2 commits July 21, 2026 21:52
Bumps [github.com/oasdiff/oasdiff](https://github.com/oasdiff/oasdiff) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/oasdiff/oasdiff/releases)
- [Changelog](https://github.com/oasdiff/oasdiff/blob/main/docs/CHANGELOG-TEMPLATE.md)
- [Commits](oasdiff/oasdiff@v1.23.0...v1.24.0)

---
updated-dependencies:
- dependency-name: github.com/oasdiff/oasdiff
  dependency-version: 1.24.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
## Proposed changes

Dependabot's config only watches `/tools/cli`, so PR #1385 bumped
`github.com/oasdiff/oasdiff` to 1.24.0 (and its transitive
`kin-openapi` to 0.143.0) in `tools/cli` alone. The oasdiff diff,
checker, and load packages are actually consumed by the `tools/foas`
library, which `tools/cli` pulls in via a `replace` directive and which
shares the `tools/go.work` workspace. Leaving `tools/foas` on oasdiff
1.23.0 / kin-openapi 0.140.0 left the workspace on skewed versions:
under the workspace and the replace directive MVS resolves oasdiff to
1.24.0, but `tools/foas/go.sum` had no entry for it, so building and
testing foas failed — the failing integration/e2e job flagged in the
ticket.

This aligns `tools/foas` with `tools/cli`:
- oasdiff 1.23.0 -> 1.24.0
- kin-openapi 0.140.0 -> 0.143.0
- oasdiff/yaml 0.1.0 -> 0.1.1 (indirect)
- oasdiff/yaml3 0.0.13 -> 0.0.14 (indirect)
- yuin/goldmark 1.8.2 -> 1.8.4 (indirect)

All go.sum hashes are copied verbatim from the already-verified
`tools/cli/go.sum`.

No source changes are required. oasdiff 1.24.0 only adds `validate`
lints (duplicate-enum-value, ambiguous-parameter-serialization) and
reworks internal rule-ID handling; there are no behavior changes to the
diff/checker output that the changelog and merge pipelines rely on, so
this is not a behavior-breaking upgrade and the golden fixtures are
unaffected. The kin-openapi 0.143.0 removal of the generic
`openapi3.StringMap[V]` type (now plain `map[string]V`) does not affect
foas: the token `StringMap` never appears in the module, and the one
site that reads `Discriminator.Mapping` ranges over it and accesses the
unchanged `MappingRef` value, which compiles identically.

_Jira ticket:_ CLOUDP-427906

## Checklist

- [x] I have signed the MongoDB CLA
- [ ] I have added tests that prove my fix is effective or that my feature works

A dependency-version alignment carries no new behavior to test; the
existing foas and CLI unit/e2e suites cover the oasdiff-backed paths.
@mongodb-sage-bot

Copy link
Copy Markdown
Contributor Author

Sage Bot can help with this pull request. Just @sage-bot in comments and I'll start working on changes in this branch.
Learn more about Sage Bot

@matt-condon
matt-condon changed the base branch from dependabot/go_modules/tools/cli/github.com/oasdiff/oasdiff-1.24.0 to main July 28, 2026 10:16
@matt-condon matt-condon changed the title CLOUDP-427906: sync oasdiff 1.24.0 upgrade into foas module chore: bump github.com/oasdiff/oasdiff from 1.23.0 to 1.24.0 in /tools/cli- #1385 Jul 28, 2026
@matt-condon

Copy link
Copy Markdown
Collaborator

@sage-bot this PR is now pointed to the main branch.
We're seeing e2e test failures related to the oasdiff package upgrade
Could you validate and address the failures?

Pipeline: https://github.com/mongodb/openapi/actions/runs/30350390783/job/90246462622?pr=1398

Failures:

 --- PASS: TestChangelog/Generate_Changelog_with_new_API_Version (17.26s)
    --- FAIL: TestChangelog/Generate_Changelog_with_same_API_Version (16.21s)
    --- PASS: TestChangelog/Generate_Changelog_with_new_Preview_API_Version (17.38s)
    --- PASS: TestChangelog/Generate_Changelog_with_renamed_API_Version (17.31s)
    --- FAIL: TestChangelog/Generate_Changelog_with_Upcoming_API_Version (87.16s)

@mongodb-sage-bot

mongodb-sage-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Sage Bot - Unexpected Error

Sage Bot ran into an unexpected error processing your request. If you need help, reach out in #ask-devprod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant