Skip to content

fix(test): keymap not rendering correctly if row5 has two keys (@fehmer) #8121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fehmer wants to merge 6 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix(test): keymap not rendering correctly if row5 has two keys (@fehmer) #8121

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f96df32
fix(test): keymap not rendering correctly if row5 has two keys (@fehmer)
fehmer Jun 16, 2026
3fa57e0
impr
fehmer Jun 16, 2026
77b9dbb
don't break on unknown keycode
fehmer Jun 16, 2026
12964c8
oops
fehmer Jun 17, 2026
c8ef5f8
remove data-key from matrix with right column
fehmer Jun 17, 2026
1efd4d5
cleanup
fehmer Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/ts/elements/keymap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ function buildRow(options: {
// potential second space in next loop iterations will be empty:
layoutDisplay = "";
} else {
keysHtml += `<div class="keymapKey ${side}">
keysHtml += `<div class="keymapKey ${side}" data-key="${keyVisualValue.join(keyDataDelimiter)}">
<div class="letter">${keyDisplay}</div>
</div>`;
r5Grid += "1";
Expand Down Expand Up @@ -586,7 +586,7 @@ async function updateLegends(): Promise<void> {

const keycode = KeyConverter.layoutKeyToKeycode(lowerCaseCharacter, layout);
if (keycode === undefined) {
return;
continue;
}
const oppositeShift = ShiftTracker.isUsingOppositeShift(keycode);

Expand Down
Loading