feat(theme): add india theme (@sachinbalagam)#8124
Open
SachinBalagam wants to merge 1 commit into
Open
Conversation
Member
|
hi @SachinBalagam , thank you for your contribution. This theme is very similar to the existing |
Author
Hi @fehmer Thanks for the feedback. I'd love to understand your theme evaluation criteria better. Do you use any specific color distance metric or contrast ratio checks to determine similarity, or is it based on overall visual feel? To illustrate the differences, here is a quick comparison of the palettes:
Please let me know if you would like me to adjust any of these to better fit the repository's guidelines! |
Member
it all boils down to @Miodec liking the theme or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new theme named
indiabased on the official Indian Tricolor flag colors.#111215) to provide proper readability and contrast.#b36b20) for clear distinction.#ffffff).#138808).#ffffff).Checks
packages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themesCloses #
