sqlite: Further cleanup how labels are handled#3487
Open
badboy wants to merge 5 commits into
Open
Conversation
Member
Author
|
the most important part here is
|
badboy
force-pushed
the
sqlite/remove-unused-code
branch
from
a91b007 to
97a8213
Compare
badboy
force-pushed
the
sqlite/metric-labels
branch
from
b861171 to
18b377a
Compare
…ater point downside: slightly worse error messages, but maybe we can inline them
This is another BREAKING CHANGE in the return type. We can't return references to the labels anymore, we need owned values.
badboy
force-pushed
the
sqlite/metric-labels
branch
from
18b377a to
c51e1e6
Compare
badboy
force-pushed
the
sqlite/remove-unused-code
branch
from
97a8213 to
6d99444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the rest of #3481 basically, bringing it all into good shape.