sqlite: tests! Reenabling and adding a whole lot of them.#3489
Open
badboy wants to merge 5 commits into
Open
Conversation
badboy
force-pushed
the
sqlite/rkv-migration
branch
2 times, most recently
from
5990091 to
0da9f2b
Compare
badboy
force-pushed
the
sqlite/rkv-migration
branch
from
0da9f2b to
d7bdb39
Compare
badboy
force-pushed
the
sqlite/rkv-migration
branch
from
d7bdb39 to
cb9ef95
Compare
badboy
force-pushed
the
sqlite/rkv-migration
branch
from
cb9ef95 to
79d8ba3
Compare
These tests were disabled because they are very rkv-specific: Manually opening and writing to an Rkv database in the format that Glean expects. Then testing Glean behaves accordingly. We now do the same, but do it in SQL.
What individual tests do should be clear from their name or further comments inline.
This currently fails. The database is locked, so Glean can't access it. It's unclear how we should handle that. It's not a particular likely case to happen in practice.
The data was generated with
cargo run -p glean-tests --bin verify-data -- tmp
on an Rkv-powered Glean checkout.
The database (`tmp/db/data.safe.bin`) was then copied into glean-core/rlb/tests/rkv-database.safe.bin
badboy
force-pushed
the
sqlite/rkv-migration
branch
from
79d8ba3 to
cd9b97b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.