Validate PE attribute certificate table bounds#488
Merged
mtrojnar merged 3 commits intomtrojnar:masterfrom Feb 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: N/A
Current Behavior
The PE signature (attribute certificate) table is parsed without sufficient validation of offsets and lengths, which may lead to out-of-bounds reads or infinite loops when processing malformed inputs.
New Behavior
The signature table is now validated against file bounds, entry sizes, and alignment rules, causing malformed inputs to be rejected safely.
Scope of Changes
Added bounds and consistency checks to PE signature table validation; no behavior changes for valid PE files.
Testing
Additional Notes
License Declaration