Skip to content

[select] Refactor touch modality check #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
atomiks merged 1 commit into from
Dec 9, 2025
Merged

[select] Refactor touch modality check #3460

atomiks merged 1 commit into from
Dec 9, 2025
+35 −18

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 7, 2025

Refactors Select to use the useOpenInteractionType hook as with other components.

@atomiks atomiks added component: select Changes related to the select component. internal Behind-the-scenes enhancement. Formerly called “core”. labels Dec 7, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 7, 2025 •
edited
Loading

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3460

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3460

commit: b4841b5

@mui-bot
Copy link

mui-bot commented Dec 7, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+6B(0.00%) 🔺+42B(+0.03%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 7, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit b4841b5
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6938a2dcd1eb8d00082cd589
😎 Deploy Preview https://deploy-preview-3460--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the fix/select-touch-modality branch from 563e19d to 342f2e4 Compare December 7, 2025 23:56
@atomiks atomiks marked this pull request as ready for review December 8, 2025 10:48
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 9, 2025
@atomiks atomiks force-pushed the fix/select-touch-modality branch from 342f2e4 to b4841b5 Compare December 9, 2025 22:29
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 9, 2025
@atomiks atomiks merged commit 3fa6c97 into mui:master Dec 9, 2025
21 of 22 checks passed
@atomiks atomiks deleted the fix/select-touch-modality branch December 9, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaldudak michaldudak michaldudak approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees

No one assigned

Labels

component: select Changes related to the select component. internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atomiks @mui-bot @michaldudak