Added Append method for tables#163
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the TUI table helper to support buffering rows on the table instance (via Append) and rendering them later (via Write), instead of requiring all rows to be passed directly to Write.
Changes:
- Added an internal
rows []Tbuffer plus a newAppend(rows ...T)method ontable. - Updated
Writeto render from buffered rows (and to accept optional rows to append before rendering), then flush the buffer after writing. - Extended tests to validate newline behavior and that buffered rows are flushed after a write.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/tui/table.go | Adds buffered row storage with Append, updates Write to render/flush buffered rows. |
| pkg/tui/table_test.go | Updates tests to use Append and adds a flush regression test for buffered rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
tablecomponent in the TUI package to support buffered row management, allowing rows to be appended and automatically flushed on write. It also introduces new tests to ensure the correct behavior of row buffering and flushing.Enhancements to table row management:
rowsfield to thetablestruct to buffer appended rows before rendering.Appendmethod ontableto add rows to the buffer.Writemethod to use buffered rows, flush them after writing, and support writing without passing rows explicitly.Testing improvements:
Appendmethod and verify newline handling.TestTableWriteFlushesBufferedRowsto confirm that buffered rows are correctly flushed after writing.