ci(cd): verify tag commit is reachable from master (#292)#313
ci(cd): verify tag commit is reachable from master (#292)#313nanotaboada merged 2 commits intomasterfrom
Conversation
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA verification step was added to the CD workflow to check whether a tag's commit is reachable from the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Assessment against linked issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 30 30
===========================================
Files 2 2
Lines 88 88
Branches 8 8
===========================================
Hits 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/maven-cd.yml:
- Around line 48-51: Replace the substring branch-check that greps for
"origin/master" with an exact ancestry check using git merge-base --is-ancestor:
verify that the commit referenced by github.sha is an ancestor of origin/master
by invoking git merge-base --is-ancestor with github.sha and origin/master and
fail with the same error message if it is not; update the conditional that
currently uses git branch -r ... | grep -q "origin/master" to rely on git
merge-base --is-ancestor (referencing github.sha and origin/master) so
similarly-named branches like origin/master-hotfix do not produce false
positives.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d670e9f5-6d9a-4eea-afd2-4fbb1ff92372
📒 Files selected for processing (2)
.github/workflows/maven-cd.ymlCHANGELOG.md
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|



Summary
releasejob in.github/workflows/maven-cd.ymlgit branch -r --contains ${{ github.sha }}to check that the tag commit is an ancestor oforigin/master; fails with a descriptive error if notTest plan
❌ Tag commit ... is not reachable from origin/masterif the tag points to an unmerged commitCloses #292
🤖 Generated with Claude Code
This change is
Summary by CodeRabbit