Reorganize should_run tests into separate policy test file #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schefflera-Arboricola
approved these changes
Dec 30, 2025
Member
Schefflera-Arboricola
left a comment
Schefflera-Arboricola
left a comment
There was a problem hiding this comment.
Thanks @ANJAN672 !
Contributor
Author
Thanks for the review and merge. By the way, I’m planning to aim for GSoC 2026 and will keep contributing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> This PR reorganizes the should_run tests by splitting them into two categories. Integration tests for nx-parallel algorithms remain in nx_parallel/tests/test_should_run.py, while policy-specific unit tests (using dummy functions) have been moved to
nx_parallel/utils/tests/test_should_run_policies.py
->Split should_run tests into algorithm-focused tests and utility-focused policy tests, placing the latter in
nx_parallel/utils/tests/test_should_run_policies.py
->
--- Addresses the suggestion from #149 .
--- Verified that all 45 tests pass in a fresh Python 3.12 environment.
--- Formatting verified with ruff.
--- Note for maintainers: The Update function info pre-commit hook relies on sh, which fails locally on Windows, but the logic has been manually verified and is expected to pass on the Linux-based CI.