fix(file-provider): use slash prefix for child item queries.#10130
Draft
camilasan wants to merge 2 commits into
Draft
fix(file-provider): use slash prefix for child item queries.#10130camilasan wants to merge 2 commits into
camilasan wants to merge 2 commits into
Conversation
Appends "/" to directory URLs before prefix matching to prevent "A/B" from incorrectly matching children of "A/BC". Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
Member
Author
|
/backport to stable-33.0 |
Member
Author
|
/backport to stable-4.0 |
camilasan
force-pushed
the
bugfix/fpext-slash-prefix-child-queries
branch
from
119ceb1 to
431417c
Compare
Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
force-pushed
the
bugfix/fpext-slash-prefix-child-queries
branch
from
431417c to
4773801
Compare
This was referenced Jun 9, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10130.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Slash prefix in path queries — starts(with: directoryUrl) without a trailing slash incorrectly matched sibling directories that share a name prefix (e.g. photos matched photos-backup).
Summary
Renaming or deleting a folder could silently affect any sibling whose name begins with the same string — data in unrelated folders gets corrupted or deleted during sync.
Solution
Adding + "/" restricts matches to true descendants only.
Steps to test it
✅ FolderA-old and its contents must be untouched.
✅ FolderA-old must still appear and remain accessible.
Checklist
AI (if applicable)