fix(wizard): align reauthentication with account setup - #10459
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1957df8f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f03bdf0288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f03bdf0 to
c1957df
Compare
|
@claucambra can you check the quite complex test? it applied the new guidelines - but look complicated. opinion? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90296ac1d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5a64a3c to
e243ea9
Compare
9364610 to
49903f3
Compare
49903f3 to
68bb507
Compare
The QML window shares the account wizard browser-auth content, footer, dimensions, and style tokens. Keep credential replacement isolated from account creation, remove the unused provider-signup widget stack, and add integration coverage for successful and cancelled reauthentication flows. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Camila Ayres <hello@camilasan.com>
68bb507 to
d5a4b1b
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10459.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
/backport to stable-34.0 |
4 participants
Replace the legacy QWidget reauthentication dialog with a QML window that shares the account wizard browser-auth content, footer, dimensions, and style tokens.
Keep credential replacement isolated from account creation and remove the unreachable provider-signup widget stack and its orphaned helpers.
Assisted-by: Codex:GPT-5