Add S3 SSE-KMS environment variable support - #2597
Open
cuppett wants to merge 1 commit into
Open
Conversation
cuppett
added
enhancement
upstream
3. to review
Nextcloud server PR nextcloud/server#57623 added sse_kms_enabled and sse_kms_key_id objectstore arguments for AWS SSE-KMS encryption. Expose them via OBJECTSTORE_S3_SSE_KMS_ENABLED and OBJECTSTORE_S3_SSE_KMS_KEY_ID env vars, mirroring the existing SSE-C support. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>
cuppett
force-pushed
the
feat/s3-sse-kms-support
branch
from
August 18, 2026 13:00
952494a to
f2a47ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sse_kms_enabledandsse_kms_key_idobjectstorearguments to support AWS Server-Side Encryption with KMS (SSE-KMS) for S3 primary storage.OBJECTSTORE_S3_SSE_KMS_ENABLED: enables SSE-KMS using the bucket's default KMS keyOBJECTSTORE_S3_SSE_KMS_KEY_ID: specific KMS key ARN/ID to use; setting this implies SSE-KMS is enabled.config/s3.config.php(source template) and regenerated all versioned copies via./update.sh.README.mdalongside the existing SSE-C entry.Test plan
php -lon the source template and a regenerated copys3.config.phpcopies remain byte-identical to.config/s3.config.phpobjectstorearguments🤖 Generated with Claude Code