test(api): setup api test coverage for oidc method#1050
Open
saw-jan wants to merge 16 commits into
Open
Conversation
saw-jan
force-pushed
the
test/setup-api-test-coverage
branch
from
3fe5bee to
b6a7005
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
saw-jan
force-pushed
the
test/setup-api-test-coverage
branch
8 times, most recently
from
3c58fdf to
e788141
Compare
saw-jan
requested review from
Ashim-Stha,
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
nabim777,
psatyal and
wielinde
as code owners
nabim777
reviewed
Jun 30, 2026
| # SPDX-License-Identifier: AGPL-3.0-or-later | ||
| Feature: setup the integration with OIDC method | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Do we need extra apps(OIDC) installed and enabled or not to run this test?
Collaborator
Author
There was a problem hiding this comment.
yes, that should be the part of the setup.
saw-jan
commented
Jun 30, 2026
saw-jan
force-pushed
the
test/setup-api-test-coverage
branch
2 times, most recently
from
594988c to
24560bd
Compare
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Co-authored-by: Nalem7 <61624650+nabim777@users.noreply.github.com> Signed-off-by: Sawjan Gurung <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
test/setup-api-test-coverage
branch
from
24560bd to
1e45dbc
Compare
PHP Code CoverageCoverage after merging test/setup-api-test-coverage into release/2.11 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nabim777
reviewed
Jul 1, 2026
| */ | ||
| public function theHTTPStatusCodeShouldBe( | ||
| $expectedStatusCode, ?string $message = "", $response = null | ||
| mixed $expectedStatusCode, ?string $message = "", $response = null |
Collaborator
There was a problem hiding this comment.
Suggested change
| mixed $expectedStatusCode, ?string $message = "", $response = null | |
| mixed $expectedStatusCode, ?string $message = "", ?ResponseInterface $response = null |
nabim777
reviewed
Jul 1, 2026
| */ | ||
| public function theOCSStatusShouldBe( | ||
| mixed $expectedStatus, | ||
| ResponseInterface $response = null |
Collaborator
There was a problem hiding this comment.
Suggested change
| ResponseInterface $response = null | |
| ?ResponseInterface $response = null |
nabim777
reviewed
Jul 1, 2026
nabim777
left a comment
nabim777
left a comment
Collaborator
There was a problem hiding this comment.
Beside above comment
LGTM 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue or Workpackage
Types of changes
Checklist:
CHANGELOG.mdfile