WIP: fix(encryption): store key by fileId for CollectiveMountPoint#59343
Draft
WIP: fix(encryption): store key by fileId for CollectiveMountPoint#59343
Conversation
Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Collectives, we can have different paths to a file by user (when a user changes their
user_folderuser setting). This leads to inaccessible files with server-side encryption as the encryption keys are stored by file path. In order to fix this, we should switch tofileIdbased key storage instead of file path based key storage.TODO
fileId, or just forISystemMountPointor just forCollectiveMountPoint$fileIdthrough encryption storage wrapper or whether it's acceptable to use$this->rootView->getFileInfo()inUtil.php.Checklist
3. to review, feature component)stable32)AI (if applicable)