Skip to content

fix: split large Content-Security-Policy headers over multiple HTTP headers #60337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n-iv wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: split large Content-Security-Policy headers over multiple HTTP headers #60337

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04e5ce2
fix: split large Content-Security-Policy headers over multiple HTTP h…
n-iv May 12, 2026
d31ffcc
fix indents
n-iv May 12, 2026
b3101fe
Add comments for hardcoded 7800
n-iv May 12, 2026
5f66758
Update lib/private/AppFramework/Http/Output.php
n-iv May 13, 2026
95470a8
Update lib/private/AppFramework/Http/Output.php
n-iv May 13, 2026
bd7e780
Merge branch 'master' into fix/csp-header-split-for-large-policies
n-iv May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions lib/private/AppFramework/Http/Output.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,34 @@ public function setReadfile($path) {
*/
#[\Override]
public function setHeader($header) {
// Apache mod_proxy_fcgi parses FCGI response headers with a buffer
// hardcoded at HUGE_STRING_LEN (8192 bytes in httpd.h); 7800 leaves
// a safety margin for the status line and surrounding header bytes.
$maxLen = 7800;
Comment thread
n-iv marked this conversation as resolved.
if (strlen($header) > $maxLen) {
foreach (['Content-Security-Policy:', 'Feature-Policy:'] as $prefix) {
if (str_starts_with($header, $prefix)) {
$value = ltrim(substr($header, strlen($prefix)));
$directives = array_filter(array_map(trim(...), explode(';', $value)));
$segment = '';
$first = true;
foreach ($directives as $directive) {
$candidate = $segment === '' ? $directive : $segment . ';' . $directive;
if (strlen($prefix . ' ' . $candidate . ';') > $maxLen && $segment !== '') {
header($prefix . ' ' . $segment . ';', $first);
$first = false;
$segment = $directive;
} else {
$segment = $candidate;
}
}
if ($segment !== '') {
header($prefix . ' ' . $segment . ';', $first);
}
Comment thread
n-iv marked this conversation as resolved.
return;
}
}
}
header($header);
}

Expand Down