Skip to content

fix(a11y): label account QR code button#60616

Open
Will-thom wants to merge 1 commit into
nextcloud:masterfrom
Will-thom:issue-60292-a11y-header-buttons
Open

fix(a11y): label account QR code button#60616
Will-thom wants to merge 1 commit into
nextcloud:masterfrom
Will-thom:issue-60292-a11y-header-buttons

Conversation

@Will-thom
Copy link
Copy Markdown

Summary

  • Add an accessible label to the account menu QR code icon-only button.
  • Add coverage for the QR code button accessible name.
  • Add coverage that the app menu trigger buttons expose accessible labels.

Fixes #60292

Tests

  • npx vitest run --project nextcloud-ui-legacy core/src/tests/components/AccountMenuProfileEntry.spec.ts core/src/tests/components/AppMenu.spec.ts
  • npm run lint
  • git diff --check origin/master...HEAD

Validated in a clean Docker container from a fresh nextcloud/server clone using node:24-bookworm.

@Will-thom Will-thom requested a review from a team as a code owner May 20, 2026 15:39
@Will-thom Will-thom requested review from nfebe, sorbaugh and susnux and removed request for a team May 20, 2026 15:39
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, thank you

@susnux susnux requested review from pringelmann and szaimen and removed request for sorbaugh May 20, 2026 15:48
@susnux susnux added bug 3. to review Waiting for reviews labels May 20, 2026
@susnux susnux added this to the Nextcloud 35 milestone May 20, 2026
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NcButton accessibility warning fires twice on every logged-in page load (UserMenu, MainMenu)

3 participants