docs: Add PLM policy source tutorial and copy edits for NGF WAF integration - #2197
Open
travisamartin wants to merge 43 commits into
Open
docs: Add PLM policy source tutorial and copy edits for NGF WAF integration#2197travisamartin wants to merge 43 commits into
travisamartin wants to merge 43 commits into
Conversation
Satisfies TECHDOCS-5343 (Story 3) and TECHDOCS-5347 (Story 7) for the NGF + F5 WAF for NGINX with PLM tutorial. Story 3 — Deploy PLM infrastructure (shared include): - Add content/includes/waf/plm-deploy-infrastructure.md - Covers PLM architecture (Policy Controller → gRPC → compiler → SeaweedFS/S3), CRD installation, registry pull secret creation, Helm install with plm-values.yaml, and deployment verification - No NGF-specific content; consumable by the NIC tutorial unmodified - Flags open item: registry token credential (TECHDOCS-5342) Story 7 — Define the WAF policy (NGF content + shared include): - Add content/includes/waf/plm-define-policy-bundle-method.md (precompiled-bundle method; product-neutral shared include) - Add inline and Git-reference methods directly to get-started-plm.md as NGF-specific content - Documents correct recompile trigger (spec/annotation change required; controller does not poll Git or Artifactory) - Documents bundle.state values: pending | processing | ready | invalid - Documents isCompiled: false for precompiled bundles Also updates get-started-plm.md with TODO placeholders for all remaining sections (Stories 2, 4, 5, 6, 8, 9, 10, 11).
✅ Deploy Preview will be available once build job completes!
|
Remove the hard-coded NGINX Gateway Fabric product name from the deploy-infrastructure include. The separate-Helm-charts note now refers to the NGINX data plane generically so both the NGF and NIC tutorials can consume the include unmodified. Also adds the NIC target file to f5-files front matter in both includes.
Headings in include files cause TOC and hierarchy issues depending on the level of the section they are embedded in. Replace all ### and #### headings with bold lead-in sentences.
Match heading levels to the consuming section in each case: - plm-deploy-infrastructure.md: ### (consumed under ##) - plm-define-policy-bundle-method.md: #### (consumed under ###) Ensures TOC entries and visual hierarchy are consistent with the parallel method subsections in get-started-plm.md.
sjberman
reviewed
Aug 10, 2026
vepatel
reviewed
Aug 10, 2026
sjberman
reviewed
Aug 10, 2026
Contributor
|
We probably need some consistency brought into this doc. In NGF, we avoid placeholder values as much as possible (except for sensitive info) so that a user can just copy/paste commands. The PLM docs don't follow this right now. |
Address PR feedback (sjberman): avoid placeholder values where possible
so commands are copy-pasteable.
- Namespace: plm-system (matches plm-storage-service.plm-system URL
already used in the NGF guide)
- Release name: plm
- Version: {{< version-waf-policy-controller >}} shortcode (already
exists at 5.14.0; auto-updates with future releases)
Sensitive values retained as placeholders: <JWT>,
<BASE64_NGINX_REPO_CRT>, <BASE64_NGINX_REPO_KEY>.
Apply F5 style guide rules across four files: - get-started-plm.md - overview.md - policy-sources.md - cli-help.md (lines 47-51, PLM storage flags) Changes applied: - em-dash: replace all em dashes with commas, periods, colons, or parentheses; use -- only where unavoidable - latin-abbreviations: via → through/using; since (causal) → because - ensure-vs-make-sure: ensure → make sure - contractions: does not/cannot → doesn't/can't per Modern Voice - possessives: PLM's in-cluster storage → in-cluster PLM storage - word-list: ensures that → means; enables → results in - placeholders: <namespace>/ → <NAMESPACE>/ per formatting rules - sensitive-information: non-RFC-5737 IP replaced with 192.0.2.1 - f5-product-names: PLM storage flag descriptions spell out Policy Lifecycle Manager on first mention - Removed redundant heading: NGINX Instance Manager (NGINX Instance Manager) → NGINX Instance Manager - Updated f5-description in policy-sources.md to include PLM
- possessives: fix PLM's, NGINX Agent's (product name possessives recasted using 'of' or restructured) - em-dash: fix reverted em dash in get-started-plm.md - sentence-length: split long Bundles sentence in overview.md - grammar: 'begins at fetching' → 'begins with fetching' - active-voice: recast passive 'to be set up' → 'to be configured' in overview.md call-out - possessives: Gateway's parametersRef → parametersRef field on a Gateway (inanimate object restructured)
- Add maintainer HTML comment noting the APPolicy CRD prerequisite
and directing future reusers to add a parent-document note
- Convert the 'Update a precompiled bundle' step to inline EOF pattern,
consistent with the initial apply step
- Add placeholder explanation ('Replace <X>, <Y>, and <Z> with your
values') before the update code block, following the pattern used
elsewhere in the include
JTorreG
reviewed
Aug 12, 2026
| - content/nic/waf-integration/get-started-plm.md | ||
| --- | ||
|
|
||
| <!-- Maintainer note: This include assumes the APPolicy CRD is already installed. In the NGF and NIC tutorials, CRD installation happens in the "Deploy PLM infrastructure" section. If you reuse this include elsewhere, add a prerequisite note in the parent document confirming CRDs are present before this section. --> |
Contributor
There was a problem hiding this comment.
wondering if notes could be a metadata field like f5-note
JTorreG
reviewed
Aug 12, 2026
shaun-nx
reviewed
Aug 12, 2026
shaun-nx
reviewed
Aug 12, 2026
shaun-nx
reviewed
Aug 12, 2026
shaun-nx
reviewed
Aug 12, 2026
shaun-nx
reviewed
Aug 12, 2026
Co-authored-by: Shaun <s.odonovan@f5.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
…ocumentation into techdocs-5345-deploy-plm
ohad-perets
reviewed
Aug 13, 2026
ohad-perets
reviewed
Aug 13, 2026
ohad-perets
reviewed
Aug 13, 2026
Helm installs CRDs on first install automatically, so the manual kubectl apply step is only required when upgrading. Relocate it from the top of the install flow (where it misled new users) to a new "Update the CRDs" section after "Verify the deployment". Add a note clarifying that the step can be skipped on a fresh install. Remove the redundant CRD verification block from the upgrade section, as the verify section already confirms CRD presence. Also pins the GitHub raw URL to the versioned tag using the version-waf-policy-controller shortcode, replacing the previous reference to main.
- Rewrite registry pull secret steps to store the JWT in a Kubernetes Secret before use, avoiding inline JWT exposure - Add JWT download steps to get-started-plm.md prerequisites, reorder prereqs so JWT comes before the registry Secret - Copy edit download-jwt.md include: active voice in call-out, bold UI labels separated, update f5-files consumer list
- Add content/includes/waf/plm-prerequisites.md with PLM-specific
prerequisites (StorageClass, Helm, JWT) and SeaweedFS storage
defaults (embedded S3 store, default pod topology, credential
Secret, HTTP-by-default note)
- Restructure get-started-plm.md Before you begin: add PLM
prerequisites subsection, add Example values H3
- Copy edit get-started-plm.md: fix causal 'since' → 'because',
remove hedge ('should show'), split two-action step, rewrite
passive results, tighten team-ownership callouts, fix directional
reference, fix 'this guide' → 'this tutorial'
- Copy edit plm-define-policy-bundle-method.md: use contraction
('doesn't poll')
The PLM chart does not generate TLS certificates. If certificates.enabled is set to true in the seaweedfsOperatorConfig, all five Secrets (CA, master, volume, filer, client) must be pre-created before running helm upgrade --install. Missing Secrets cause SeaweedFS pods to fail on mount. Add an optional TLS subsection to the 'Install the Policy Controller' section that: - States TLS is off by default - Shows the certificates block with the five secretName keys - Warns explicitly that the chart does not generate certificates - Provides kubectl create secret commands for each required Secret - Explains the PKI prerequisite Resolves feedback from code review.
travisamartin
commented
Aug 14, 2026
| pullSecrets: regcred | ||
| ``` | ||
|
|
||
| #### Enable TLS for PLM storage (optional) |
Contributor
Author
There was a problem hiding this comment.
This new section addresses the comment above.
This section is AI-generated and needs SME review before accepting.
The SeaweedFS operator deployment becomes Available before it reconciles the SeaweedFS CR and creates the SeaweedFS pods. This means kubectl wait --selector app.kubernetes.io/name=seaweedfs can exit immediately with no matches (and therefore an error) during the window between the operator being ready and the pods being created. Replace the two-step wait with a polling loop that retries kubectl wait every 5 seconds until either all SeaweedFS pods are Ready or a 300s timeout is exceeded.
- Add '#### Install the chart' heading before the helm repo add / helm upgrade commands to visually separate them from the optional TLS subsection. Without this heading, the install commands appeared to be continuation content of the TLS section rather than a step for all readers. - Replace inline skip note on '### Update the CRDs' with a note call-out so the upgrade-only scope is the first thing readers see before the imperative content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds documentation for using Policy Lifecycle Management (PLM) as a WAF policy source in NGINX Gateway Fabric, and applies style guide copy edits across the NGF WAF integration docs.
New files
content/includes/waf/plm-deploy-infrastructure.mdA shared include covering PLM backend deployment. Consumable by both the NGINX Gateway Fabric and NGINX Ingress Controller tutorials without modification. Covers:
appolicies,aplogconfs,apusersigs,apsignatures)plm-values.yaml(uses theversion-waf-policy-controllershortcode for the chart version)content/includes/waf/plm-define-policy-bundle-method.mdA shared include covering the precompiled-bundle policy definition method. Product-neutral and consumable by both tutorials. Covers:
.tgzbundle from an artifact registrybundle.statevalues (pending,processing,ready,invalid)isCompiled: falsebehaviorAPPolicyresource (the Policy Controller does not poll)content/ngf/waf-integration/get-started-plm.mdNew end-to-end tutorial for protecting traffic with F5 WAF for NGINX using PLM in NGINX Gateway Fabric. Covers:
WAFPolicyUpdated files
content/ngf/waf-integration/overview.mdcontent/ngf/waf-integration/policy-sources.mdcontent/ngf/reference/cli-help.md(PLM storage flags)Copy edits applying the F5 style guide:
via→through/using)since(causal) withbecauseensurewithmake surePLM's,NGINX Agent's)<namespace>/→<NAMESPACE>/)10.96.20.187→192.0.2.1) across six filesf5-descriptioninpolicy-sources.mdto include PLMpolicy-sources.mdOpen questions for SME review