fix: move tsconfig.json to project root - #1021
Merged
Merged
Conversation
The packages/core/tsconfig.json only covered packages/core/src, leaving packages/react and packages/node-legacy without a TypeScript project context. This caused type errors in their types.d.ts files that reference global types (GeneratorMetadata, Generate, ProcessChunk) declared in packages/core/src/generators/types.d.ts. A root tsconfig.json with include: ["packages/*/src"] ensures all packages share a single compilation context where the global type declarations are visible everywhere.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 89.39% 89.39%
=======================================
Files 203 203
Lines 18796 18796
Branches 1753 1753
=======================================
Hits 16803 16803
Misses 1986 1986
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Fast-tracked for RenderATL |
Member
I don't think RenderATL is a reason for fast-tracking arbitrary PRs... I mean, you could have approved the PR and ask for fast-tracking and we'd give a 👍 but should have at least waited for that imo 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages/core/tsconfig.json only covered packages/core/src, leaving packages/react and packages/node-legacy without a TypeScript project context. This caused type errors in their types.d.ts files that reference global types (GeneratorMetadata, Generate, ProcessChunk) declared in packages/core/src/generators/types.d.ts.
A root tsconfig.json with include: ["packages/*/src"] ensures all packages share a single compilation context where the global type declarations are visible everywhere.
Description
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.