Skip to content

cli: add --max-http-header-size flag#24811

Merged
cjihrig merged 3 commits intonodejs:masterfrom
cjihrig:max-headers-size
Dec 20, 2018
Merged

cli: add --max-http-header-size flag#24811
cjihrig merged 3 commits intonodejs:masterfrom
cjihrig:max-headers-size

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 3, 2018 •
edited
Loading

Allow the maximum size of HTTP headers to be overridden from the command line.

Refs: nodejs/http-parser#453
Fixes: #24692

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@bnoordhuis bnoordhuis bnoordhuis left review comments

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Trott Trott Trott left review comments

+4 more reviewers

@JSMike JSMike JSMike left review comments

@vdeturckheim vdeturckheim vdeturckheim left review comments

@MylesBorins MylesBorins MylesBorins approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make HTTP_MAX_HEADER_SIZE configurable