test_runner: add env option to run function #61367
Open
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
pmarchini
reviewed
Jan 13, 2026
avivkeller
approved these changes
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61367 +/- ##
=======================================
Coverage 88.51% 88.52%
=======================================
Files 704 704
Lines 208739 208786 +47
Branches 40274 40306 +32
=======================================
+ Hits 184770 184827 +57
+ Misses 15968 15956 -12
- Partials 8001 8003 +2
🚀 New features to boost your workflow:
|
Support an `env` option that is passed to the underlying child_process. Fixes: nodejs#60709
Ethan-Arrowood
force-pushed
the
test-runner-env-option
branch
from
724b84e to
cd4d84e
Compare
Ethan-Arrowood
requested review from
avivkeller,
ljharb,
mcollina and
pmarchini
pmarchini
reviewed
Jan 14, 2026
| const args = getRunArgs(path, opts); | ||
| const stdio = ['pipe', 'pipe', 'pipe']; | ||
| const env = { __proto__: null, ...process.env, NODE_TEST_CONTEXT: 'child-v8' }; | ||
| const env = opts.env || { __proto__: null, ...process.env, NODE_TEST_CONTEXT: 'child-v8' }; |
Member
There was a problem hiding this comment.
NODE_TEST_CONTEXT is used by the test runner to identify the runner subprocesses, and removing it may cause issues with the reporters.
It must be preserved even if the user passes opts.env.
I would suggest, in any case, adding a snapshot test when using this option to cover the E2E once the option has been provided!
pmarchini
reviewed
Jan 14, 2026
| * `functionCoverage` {number} Require a minimum percent of covered functions. If code | ||
| coverage does not reach the threshold specified, the process will exit with code `1`. | ||
| **Default:** `0`. | ||
| * `env` {Object} Specify environment variables to be passed along to the test process. This options is not compatible with `isolation='none'`. |
Member
There was a problem hiding this comment.
I think it might be worth specifying here that these variables will override those from the main process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support an
envoption that is passed to theunderlying child_process.
Fixes: #60709