tools: fix timeout errors in lint-nix job#62265
Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom Mar 17, 2026
Merged
tools: fix timeout errors in lint-nix job#62265nodejs-github-bot merged 4 commits intonodejs:mainfrom
lint-nix job#62265nodejs-github-bot merged 4 commits intonodejs:mainfrom
Conversation
mertcanaltin
approved these changes
Mar 15, 2026
cjihrig
approved these changes
Mar 16, 2026
Renegade334
approved these changes
Mar 16, 2026
Member
Renegade334
left a comment
Renegade334
left a comment
There was a problem hiding this comment.
update-nixpkgs-pin won't remove this, so it might be worth a TODO comment to remove once the patch makes it to a release.
Contributor
Author
Note that this is a simple revert, not exactly a patch, so it's unlikely to land upstream (I would expect they land a proper fix). If the nixpkgs pin updates the version of treefmt and the commit no longer reverts cleanly (which would likely happen when a proper fix (or even a revert) lands), we should see the lint-nix job fail. |
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3db2206 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #62219