Skip to content

repl: fix crash when bare 'import' is typed #63552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WaqarNiaxi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

repl: fix crash when bare 'import' is typed #63552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df02a83
repl: fix crash when bare 'import' is typed
WaqarNiaxi May 25, 2026
78fa809
test: avoid spawning repl import crash regression test
WaqarNiaxi Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,12 @@ writer.options = { ...inspect.defaultOptions, showProxy: true };
// Converts static import statement to dynamic import statement
const toDynamicImport = (codeLine) => {
let dynamicImportStatement = '';
const ast = acornParse(codeLine, { __proto__: null, sourceType: 'module', ecmaVersion: 'latest' });
let ast;
try {
ast = acornParse(codeLine, { __proto__: null, sourceType: 'module', ecmaVersion: 'latest' });
} catch {
return codeLine;
}
acornWalk.ancestor(ast, {
ImportDeclaration(node) {
const awaitDynamicImport = `await import(${JSONStringify(node.source.value)});`;
Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-repl-import-incomplete-crash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
'use strict';
require('../common');
const repl = require('repl');

// Regression test for https://github.com/nodejs/node/issues/63551:
// Typing a bare `import` keyword in the REPL must not crash the process.
const replserver = new repl.REPLServer();

replserver.emit('line', 'import');
replserver.emit('line', '.exit');