tools: remove skip logic in commit-queue.sh - #65162
Open
aduh95 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
MrJithil
approved these changes
Aug 9, 2026
panva
approved these changes
Aug 9, 2026
atlowChemi
approved these changes
Aug 9, 2026
atlowChemi
added
the
author ready
lpinca
approved these changes
Aug 9, 2026
avivkeller
approved these changes
Aug 9, 2026
avivkeller
added
the
commit-queue
bjohansebas
approved these changes
Aug 9, 2026
avivkeller
added
commit-queue-failed
Member
Commit Queue failed- Loading data for nodejs/node/pull/65162 ✔ Done loading data for nodejs/node/pull/65162 ----------------------------------- PR info ------------------------------------ Title tools: remove skip logic in `commit-queue.sh` (#65162) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:no-skip-cq -> nodejs:main Labels tools, author ready, commit-queue Commits 1 - tools: remove skip logic in `commit-queue.sh` Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65162 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65162 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 10:50:51 GMT ✔ Approvals: 5 ✔ - Jithil P Ponnan (@MrJithil): https://github.com/nodejs/node/pull/65162#pullrequestreview-4891203384 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65162#pullrequestreview-4891215229 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65162#pullrequestreview-4891266842 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65162#pullrequestreview-4891414879 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65162#pullrequestreview-4891594119 ✘ This PR needs to wait 36 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /Users/avivkeller/Documents/projects/nodejs/node/.ncu/nodejs/node/actions/runs/ |
avivkeller
added
commit-queue
trivikr
approved these changes
Aug 10, 2026
cjihrig
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64343 has added a filter logic in
commit-queue.ymlthat's based on the work in nodejs/node-core-utils#1113, so the additional logic incommit-queue.shmakes the CQ harder to follow. It also fails to report that some PRs (e.g. #64969, in https://github.com/nodejs/node/actions/runs/31308173647/job/93231744025#step:8:33) are stuck because of a phantom job reported in GH status (despite having green CI)