Skip to content

fix: Pass through sourcemaps#76

Merged
timfish merged 4 commits into
mainfrom
fix/sourcemaps
Jun 18, 2026
Merged

fix: Pass through sourcemaps#76
timfish merged 4 commits into
mainfrom
fix/sourcemaps

Conversation

@timfish

@timfish timfish commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I was testing sourcemap pass through support and found an issue!

The added test case results in the following error:

✖ produces a valid sourcemap when an inputSourceMap is provided (0.819125ms)
  TypeError [Error]: Converting circular structure to JSON
      --> starting at object with constructor 'State'
      |     property 'mapping' -> object with constructor 'Object'
      --- property 'generated' closes the circle
      at JSON.stringify (<anonymous>)
      at SourceMapGenerator.SourceMapGenerator_validateMapping [as _validateMapping] (/orchestrion-js/node_modules/source-map/lib/source-map-generator.js:298:50)
      at SourceMapGenerator.SourceMapGenerator_addMapping [as addMapping] (/orchestrion-js/node_modules/source-map/lib/source-map-generator.js:110:12)
      at State.map (/orchestrion-js/node_modules/astring/dist/astring.js:1203:26)
      at State.writeAndMap (/orchestrion-js/node_modules/astring/dist/astring.js:1179:12)
      at Object.ClassDeclaration (/orchestrion-js/node_modules/astring/dist/astring.js:515:11)
      at Object.ExportNamedDeclaration (/orchestrion-js/node_modules/astring/dist/astring.js:625:34)
      at Object.Program (/orchestrion-js/node_modules/astring/dist/astring.js:234:27)
      at generate (/orchestrion-js/node_modules/astring/dist/astring.js:1250:29)
      at Transformer.transform (/orchestrion-js/lib/transformer.js:143:20)

@timfish timfish requested review from bizob2828 and rochdev June 17, 2026 16:24

@bizob2828 bizob2828 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have a linting error but LGTM

@timfish timfish marked this pull request as draft June 17, 2026 16:57
@timfish

This comment was marked as outdated.

@timfish timfish marked this pull request as ready for review June 17, 2026 17:02
@timfish timfish requested a review from bizob2828 June 17, 2026 17:03
@timfish timfish requested review from AbhiPrasad and Qard June 17, 2026 17:34
@timfish timfish merged commit 082458b into main Jun 18, 2026
7 checks passed
@timfish timfish deleted the fix/sourcemaps branch June 18, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants