fix: allow h2 post request multiplexing#5391
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5391 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 110 110
Lines 36757 36757
=======================================
Hits 34283 34283
Misses 2474 2474 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I think the behavior change is right for H2, but I would add one more regression test with a non-buffer body, for example a |
|
@mcollina thanks for quick PR. I'll also test this in on my side and report back how is this working |
|
@mcollina I tested the PR - PR removes the non-idempotent POST busy guard, which fixes low-level This affects ordinary fetch POST JSON requests, including POST requests whose response is text/event-stream. Both of these request types we are using in Tensorlake ts sdk. Can we relax that constraints for H2? |
Summary
Fixes: #5390
Tests
node --test test/issue-5390.jsnode --test test/http2-dispatcher.js test/http2-agent.jsgit diff --check