fix(types): add optional logs parameter to filterCallsByX functions#5399
Open
mukejane wants to merge 2 commits into
Open
fix(types): add optional logs parameter to filterCallsByX functions#5399mukejane wants to merge 2 commits into
mukejane wants to merge 2 commits into
Conversation
The filterCallsByProtocol/Host/Port/Origin/Path/Hash/FullUrl/Method functions accept an optional second 'logs' parameter (defaulting to this.logs) in the JS implementation, but the TypeScript definitions were missing this parameter, causing type errors when calling these methods with the internal logs argument. Fixes nodejs#5324
…s true Per the WHATWG EventSource spec, when withCredentials is true, the request credentials mode should be 'include', not 'omit'. When corsAttributeState is 'use-credentials' (set when withCredentials === true), the credentials should be 'include'. When corsAttributeState is 'anonymous', credentials should be 'same-origin'. Fixes nodejs#5378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #5324
The
filterCallsByProtocol,filterCallsByHost,filterCallsByPort,filterCallsByOrigin,filterCallsByPath,filterCallsByHash,filterCallsByFullUrl, andfilterCallsByMethodfunctions inMockCallHistoryaccept an optional secondlogsparameter (defaulting tothis.logs) in the JS implementation, but the TypeScript type definitions were missing this parameter.This caused TypeScript errors when calling these methods with the internal
logsargument.Co-Authored-By: Claude Bounty mukejane@users.noreply.github.com