Skip to content

Fix no error-msg when a plugin download failed#96

Closed
xomx wants to merge 1 commit intonotepad-plus-plus:masterfrom
xomx:fix_no_error_msg_when_plugin_downloading_failed
Closed

Fix no error-msg when a plugin download failed#96
xomx wants to merge 1 commit intonotepad-plus-plus:masterfrom
xomx:fix_no_error_msg_when_plugin_downloading_failed

Conversation

@xomx
Copy link

@xomx xomx commented Oct 4, 2025

@xomx
Copy link
Author

xomx commented Oct 14, 2025

@donho
IDK if you've already noticed this PR?

I'm trying to fix this as I've already experienced a situation when I tried to install a plugin via PluginsAdmin but nothing happened after the N++ restart. Later I discovered that my plugin-zip downloading failed somehow (FW, net error or similar) but there wasn't a single msg about, so I tried unsuccessfully several times before I figured out what was going on...

The fix is simple but I'm not sure if the original bool isSilentMode true in:

bool isSuccessful = downloadBinary(dlUrl, dlDest, sha256ToCheck, pair<wstring, int>(extraOptions.getProxyServer(), extraOptions.getPort()), true, pair<wstring, wstring>(dlStopped, gupParams.getMessageBoxTitle()));

was not there for a deeper reason that I didn't see?

@donho
Copy link
Member

donho commented Oct 15, 2025

@xomx
Oups! Sorry, I didn't see it at all. You have done the right thing to ping me.

@donho donho self-assigned this Oct 15, 2025
@donho donho added the accept label Oct 16, 2025
@donho donho closed this in 1632fe8 Oct 16, 2025
@xomx xomx deleted the fix_no_error_msg_when_plugin_downloading_failed branch October 17, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin installations can fail silently without any error message [BUG] JSTool plugin installation fails silently with AdGuard DNS

2 participants