fix(arborist): fix peerOptional dependency resolution in buildIdealTree

[Saibamen]

Fixes #8726, fixes #6787

Tested on Windows & NodeJS v24.12.0 with package.json from #8726 (comment):

{
  "name": "testcase",
  "version": "1.0.0",
  "devDependencies": {
    "addons-linter": "6.13.0",
    "htmlhint": "1.1.4"
  }
}

[ro0NL]

[Saibamen]

FYI: Right now, this PR fixes only npm ci after npm install.

package-lock.json file still has node_modules/node-fetch version 2.7.0 instead of 2.6.11 after first call to npm install.

I will try to fix this too.

[Saibamen]

Now npm install produces a correct package-lock.json file.

[owlstronaut]

Could you unwrap the multi-line comments so each sentence/paragraph is on a single line? We avoid hard-wrapping prose in comments for accessibility as it doesn't play well with screen readers (we've been slowly converting the codebase to that anyway, it is still pretty prevalent)

[Saibamen]

Done in 95dc220 and 9c703f8

[owlstronaut]

@Saibamen looks like it needs 2 more lines of code coverage from tests as well

[G-Rath]

sounds like this should also resolve #6787, so @Saibamen might want to put that in the PR title body so that gets linked and closed when this is landed.

Thanks for working on this ❤️

[Saibamen]

put that in the PR title so that gets linked and closed when this is landed.

Linking doesn't work in PR title - you need to have it inside PR description (first comment).
And you can't use Fixed #x, #y for multiple issues... Every issue needs to be prefixed with keyword: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

[G-Rath]

yup I mistyped - I meant "body" rather than "title", and for you to do a "Fixes #xyz" for each issue 🙂

[Saibamen]

@owlstronaut Please run GH Actions again - I have 100% CC on my local git repo

[ro0NL]

hope this bc break will be fixed in the next release