fix(ui): disambiguate the two "compare" links#2180
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
6c8ff74 to
8cad609
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
281bb23 to
b241b93
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR updates the package header component to use a different i18n key for the screen-reader-only text on the compare Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
Closes #2156
🧭 Context
The two "compare" buttons when on the package page are not great UX. It isn't obvious that they do different things as they are visually identical and contain the same text.
When I first introduced it, the package page one was in a location that was very space constrained, so I used the short "compare" rather than something more specific. It has since moved to a location with more space.
📚 Description
Change the package page "compare" label to "compare this package...".
I also considered "compare to", "compare to...", "compare this package to...", "compare this to...", "compare with", "start compare...". 🤷🏼