Skip to content

fix: improve compare quadrant chart labels#2416

Open
graphieros wants to merge 4 commits intomainfrom
compare-quadrant-relabelling
Open

fix: improve compare quadrant chart labels#2416
graphieros wants to merge 4 commits intomainfrom
compare-quadrant-relabelling

Conversation

@graphieros
Copy link
Copy Markdown
Contributor

@graphieros graphieros commented Apr 8, 2026

Related to the already closed #2387

This improves the labels of the quadrant chart in the compare page, to have them more intuitive and neutral for a dev audience, and less prone to misinterpretation.

image

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 8, 2026 4:21am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 8, 2026 4:21am
npmx-lunaria Ignored Ignored Apr 8, 2026 4:21am

Request Review

@graphieros graphieros requested a review from serhalp April 8, 2026 04:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
i18n/locales/fr-FR.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

The PR adjusts watermark rendering in app/components/Compare/FacetQuadrantChart.vue (sizeRatioTagline and vertical offsets) and updates English and French localisation for the quadrant chart: axis labels changed from Adoption/Efficiency to Traction/Ergonomics, quadrant descriptor labels and explanatory/copy_alt strings were revised, and the chart title/filename were updated.

Possibly related PRs

Suggested reviewers

  • alexdln
  • ghostdevv
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR addresses the closed issue #2387 by improving the quadrant chart labels with new axis names and quadrant descriptors as shown in the accompanying image.
Out of Scope Changes check ✅ Passed All changes directly relate to relabelling the quadrant chart: component watermark adjustments, English and French localisation updates for axis/quadrant labels and descriptions.
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the motivation for relabelling the quadrant chart axes and quadrant labels for improved intuitiveness.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch compare-quadrant-relabelling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros graphieros enabled auto-merge April 8, 2026 04:12
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9cec754d-d9c2-41ea-9741-98e81745420e

📥 Commits

Reviewing files that changed from the base of the PR and between f88bbcb and 2a48d81.

📒 Files selected for processing (3)
  • app/components/Compare/FacetQuadrantChart.vue
  • i18n/locales/en.json
  • i18n/locales/fr-FR.json

@graphieros graphieros added the needs review This PR is waiting for a review from a maintainer label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review This PR is waiting for a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add quadrant chart on the compare page

1 participant