fix(catalog): resolve definition for unopened workspace files#97
fix(catalog): resolve definition for unopened workspace files#97
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR changes workspace/document resolution to prefer the language server’s in-memory documents: Possibly related PRs
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4a187603-2917-4019-96b8-dd67761ba5c7
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
packages/language-server/src/workspace.tspackages/language-service/package.jsonpackages/language-service/src/plugins/catalog.tspackages/language-service/src/plugins/hover.tspackages/language-service/src/plugins/version-completion.tspackages/language-service/src/utils/document.tspackages/language-service/src/utils/range.tspnpm-workspace.yaml
💤 Files with no reviewable changes (1)
- packages/language-service/src/utils/range.ts
Fix
go to definitionsilently failing for catalog dependencies when the workspace file was never opened in the editor.Caused by #91